[
https://issues.apache.org/jira/browse/HIVE-25006?focusedWorklogId=586529&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586529
]
ASF GitHub Bot logged work on HIVE-25006:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/21 12:33
Start Date: 21/Apr/21 12:33
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2161:
URL: https://github.com/apache/hive/pull/2161#discussion_r617490157
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
##########
@@ -346,25 +372,23 @@ private static ExecutorService
tableExecutor(Configuration conf, int maxThreadNu
/**
* Get the committed data files for this table and job.
+ *
+ * @param numTasks Number of writer tasks that produced a forCommit file
* @param executor The executor used for reading the forCommit files parallel
* @param location The location of the table
* @param jobContext The job context
* @param io The FileIO used for reading a files generated for commit
* @param throwOnFailure If <code>true</code> then it throws an exception on
failure
* @return The list of the committed data files
*/
- private static Collection<DataFile> dataFiles(ExecutorService executor,
String location, JobContext jobContext,
- FileIO io, boolean throwOnFailure) {
+ private static Collection<DataFile> dataFiles(int numTasks, ExecutorService
executor, String location,
+ JobContext jobContext, FileIO
io, boolean throwOnFailure) {
Review comment:
They are a bit confusing about this. The 4 spaces padding is indeed the
general rule for line continuation, but I've been asked earlier by Anton on
other PRs not to do that for method parameter indentations and do it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 586529)
Time Spent: 3h 20m (was: 3h 10m)
> Commit Iceberg writes in HiveMetaHook instead of TezAM
> ------------------------------------------------------
>
> Key: HIVE-25006
> URL: https://issues.apache.org/jira/browse/HIVE-25006
> Project: Hive
> Issue Type: Task
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Trigger the write commits in the HiveIcebergStorageHandler#commitInsertTable.
> This will enable us to implement insert overwrites for iceberg tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
