[
https://issues.apache.org/jira/browse/HIVE-25010?focusedWorklogId=586033&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586033
]
ASF GitHub Bot logged work on HIVE-25010:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/21 17:35
Start Date: 20/Apr/21 17:35
Worklog Time Spent: 10m
Work Description: lcspinter commented on a change in pull request #2193:
URL: https://github.com/apache/hive/pull/2193#discussion_r616899607
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -770,6 +770,8 @@ private static void populateLlapDaemonVarsSet(Set<String>
llapDaemonVarsSetLocal
"If not set, defaults to the codec extension for text files (e.g.
\".gz\"), or no extension otherwise."),
HIVE_IN_TEST("hive.in.test", false, "internal usage only, true in test
mode", true),
+ HIVE_IN_TEST_ICEBERG("hive.in.iceberg.test", false, "internal usage only,
true when " +
Review comment:
During the creation of the iceberg table an exclusive lock is requested
on the hms table. This logic is guarded by the value of `HIVE_IN_TEST` and
`HINVE_IN_TEZ_TEST`. If any of these values are true and the operationtype is
unset, we get an exception, which is the case in q tests.
```java
f (lc.isSetOperationType() && lc.getOperationType() ==
DataOperationType.UNSET &&
(MetastoreConf.getBoolVar(conf, ConfVars.HIVE_IN_TEST) ||
MetastoreConf.getBoolVar(conf, ConfVars.HIVE_IN_TEZ_TEST))) {
throw new IllegalStateException("Bug: operationType=" +
lc.getOperationType() + " for component "
+ lc + " agentInfo=" + rqst.getAgentInfo());
}
```
Changing the `HIVE_IN_TEST` to false is not the right solution, because it
is evaluated in many other places as well, activating unwanted code paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 586033)
Time Spent: 1h (was: 50m)
> Create TestIcebergCliDriver and TestIcebergNegativeCliDriver
> ------------------------------------------------------------
>
> Key: HIVE-25010
> URL: https://issues.apache.org/jira/browse/HIVE-25010
> Project: Hive
> Issue Type: Test
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We should create iceberg specific drivers to run iceberg qtests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
