[
https://issues.apache.org/jira/browse/HIVE-25005?focusedWorklogId=582551&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582551
]
ASF GitHub Bot logged work on HIVE-25005:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/21 14:32
Start Date: 14/Apr/21 14:32
Worklog Time Spent: 10m
Work Description: nrg4878 commented on a change in pull request #2171:
URL: https://github.com/apache/hive/pull/2171#discussion_r613301463
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/AbstractThriftHiveMetastore.java
##########
@@ -0,0 +1,1610 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore;
+
+import com.facebook.fb303.fb_status;
+import org.apache.hadoop.hive.metastore.api.*;
+import org.apache.hadoop.hive.metastore.api.Package;
+import org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore.Iface;
+import org.apache.thrift.TException;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * This abstract class can be extended by any remote cache that implements HMS
APIs.
+ * The idea behind introducing this abstract class is not to break the build
of remote cache,
+ * whenever we add new HMS APIs.
+ */
+public abstract class AbstractThriftHiveMetastore implements Iface {
Review comment:
Just thinking out loud here.
The name AbstractThriftHiveMetastore suggests thats it is is an abstract
class which is used internally by Hive and also extensible by other
implementations. The fact that Hive doesn't use it at all, it feels like a
Dummy implementation that should be named DummyThriftHiveMetastore or something
like that. But then, it would be odd for new concrete implementations to extend
a Dummy class.
Perhaps something like PluggableThriftHiveMetastore might be the right name
as it indicates it used to plugin new implementations.
+1 on the change for me, I will leave it to you on the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 582551)
Remaining Estimate: 0h
Time Spent: 10m
> Provide dummy implementation for HMS APIs
> ------------------------------------------
>
> Key: HIVE-25005
> URL: https://issues.apache.org/jira/browse/HIVE-25005
> Project: Hive
> Issue Type: Sub-task
> Components: HiveServer2
> Reporter: Kishen Das
> Assignee: Kishen Das
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If there is a remote cache that implements HMS APIs, it would be useful to
> have dummy implementation for all the APIs, so that any new HMS API will not
> break the build for the remote cache.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
