[
https://issues.apache.org/jira/browse/HIVE-24472?focusedWorklogId=582067&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582067
]
ASF GitHub Bot logged work on HIVE-24472:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/21 21:17
Start Date: 13/Apr/21 21:17
Worklog Time Spent: 10m
Work Description: mustafaiman commented on a change in pull request #2123:
URL: https://github.com/apache/hive/pull/2123#discussion_r612782613
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -429,6 +437,11 @@ public LlapTaskSchedulerService(TaskSchedulerContext
taskSchedulerContext, Clock
delayedTaskSchedulerExecutor =
MoreExecutors.listeningDecorator(delayedTaskSchedulerExecutorRaw);
+ ExecutorService preemptTaskSchedulerExecutorRaw =
Executors.newFixedThreadPool(1,
Review comment:
I checked that too and got confused. LlapTaskScheduler does the work of
finding preemption candidates etc. even though preemption cannot occur in the
end. Also, LlapTaskScheduler marks tasks as preempted and updates preemption
stats eventhough nothing is preempted because of
LLAP_DAEMON_TASK_SCHEDULER_ENABLE_PREEMPTION is false. Am I understanding this
correctly?
This is not the problem of this patch obviously. I am just asking to
understand. I'll +1 this regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 582067)
Time Spent: 1h 20m (was: 1h 10m)
> Optimize LlapTaskSchedulerService::preemptTasksFromMap
> ------------------------------------------------------
>
> Key: HIVE-24472
> URL: https://issues.apache.org/jira/browse/HIVE-24472
> Project: Hive
> Issue Type: Sub-task
> Reporter: Rajesh Balamohan
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: Screenshot 2020-12-03 at 12.13.03 PM.png
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> !Screenshot 2020-12-03 at 12.13.03 PM.png|width=1063,height=571!
> speculativeTasks could possibly include node information to reduce CPU burn
> in LlapTaskSchedulerService::preemptTasksFromMap
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
