[
https://issues.apache.org/jira/browse/HIVE-25003?focusedWorklogId=581826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581826
]
ASF GitHub Bot logged work on HIVE-25003:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/21 14:52
Start Date: 13/Apr/21 14:52
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2169:
URL: https://github.com/apache/hive/pull/2169#discussion_r612521207
##########
File path: pom.xml
##########
@@ -64,8 +64,7 @@
<module>standalone-metastore</module>
<module>upgrade-acid</module>
<module>kafka-handler</module>
- <module>iceberg-handler</module>
- <module>iceberg-catalog</module>
+ <module>iceberg</module>
Review comment:
Just to check, after this refactor, the handler and catalog jars are
still packaged into the `packaging/target/.../lib` directory? How about the
patched jars (core and api)? Are they correctly included into the shaded
handler jar with the patched classfiles, but not included into the packaging
`/lib`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 581826)
Time Spent: 1h 20m (was: 1h 10m)
> Move iceberg-handler under a hive-iceberg module
> ------------------------------------------------
>
> Key: HIVE-25003
> URL: https://issues.apache.org/jira/browse/HIVE-25003
> Project: Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> We should create a new {{hive-iceberg}} module and put {{iceberg-handler}}
> and subsequent iceberg modules under this module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
