[
https://issues.apache.org/jira/browse/HIVE-24978?focusedWorklogId=581801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581801
]
ASF GitHub Bot logged work on HIVE-24978:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/21 14:15
Start Date: 13/Apr/21 14:15
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #2154:
URL: https://github.com/apache/hive/pull/2154#discussion_r611252750
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionOperation.java
##########
@@ -120,6 +126,12 @@ private void dropPartitions() throws HiveException {
List<Partition> droppedPartitions =
context.getDb().dropPartitions(tablenName.getDb(), tablenName.getTable(),
partitionExpressions, options);
+ if (isRepl) {
Review comment:
It does a lot of stuff below related to ``llap`` and printing to
console, which I thought would be irrelevant here, so I added this check, So in
case of replication, I skip the below part and return from here itself
There is something like this below:
``
// We have already locked the table, don't lock the partitions.
DDLUtils.addIfAbsentByName(new WriteEntity(partition,
WriteEntity.WriteType.DDL_NO_LOCK), context);
``
This ddlUtils stuff only, I am not very sure, Let me know if you find it
relevant, I will add it in my block as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 581801)
Time Spent: 40m (was: 0.5h)
> Optimise number of DROP_PARTITION events created.
> -------------------------------------------------
>
> Key: HIVE-24978
> URL: https://issues.apache.org/jira/browse/HIVE-24978
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Even for drop partition with batches, presently there is one event for every
> partition, optimise to merge them, to save the number of calls to HMS
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
