[ 
https://issues.apache.org/jira/browse/HIVE-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949665#comment-14949665
 ] 

Xuefu Zhang commented on HIVE-11985:
------------------------------------

First I have to admit that I don't have the enough knowledge to conclude if the 
approach here causes a problem. As far as I know, 4000 character limit is only 
a problem for Oracle, yet the patch seems rejecting any schema that is more 
than 2000 long. This sounds rather harsh, and a long of times users get around 
the problem by changing Oracle settings.

On a high level, I'd echo [~ashutoshc] and [~alangates]'s concerns. If we spend 
time on this, I'd rather solve the problem in the generic way, regardless the 
serde type and db type. The obvious inconsistency I see here is that we store 
for avro the schema if it's less than 2000 while storing a constant string for 
anything over that. If we determine that it's not necessary to store it for 
avro, don't store it at all. Or if we can solve the length problem for all 
serdes, then that's probably the the right way to go.

> don't store type names in metastore when metastore type names are not used
> --------------------------------------------------------------------------
>
>                 Key: HIVE-11985
>                 URL: https://issues.apache.org/jira/browse/HIVE-11985
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-11985.01.patch, HIVE-11985.02.patch, 
> HIVE-11985.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to