[
https://issues.apache.org/jira/browse/HIVE-24965?focusedWorklogId=576381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576381
]
ASF GitHub Bot logged work on HIVE-24965:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/21 03:01
Start Date: 03/Apr/21 03:01
Worklog Time Spent: 10m
Work Description: kcheeeung commented on a change in pull request #2141:
URL: https://github.com/apache/hive/pull/2141#discussion_r606607691
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java
##########
@@ -148,7 +148,8 @@ private void getColumnsNoColumnPath(Table table, Partition
partition, List<Field
// Fetch partition statistics only for describe extended or formatted.
if (desc.isExtended() || desc.isFormatted()) {
- if (table.isPartitioned() && partition == null) {
+ boolean shouldGetPartStats = MetastoreConf.getBoolVar(context.getConf(),
MetastoreConf.ConfVars.DESCTABLE_ENABLE_PARTITION_STATS);
+ if (table.isPartitioned() && partition == null && shouldGetPartStats) {
Review comment:
Added the tests. Let me know if I did it right. Here are the steps I did
1. `mvn test -Dtest=TestCliDriver -Dqfile=describe_table.q
-Dtest.output.overwrite=true`
2. It actually made a new output file and was in
`ql/src/test/results/clientpositive/`
3. I saw `describe_table.q.out` in the OSS is actually in a different path
`ql/src/test/results/clientpositive/llap`. What I did was to move the new
output file to the correct location and that's how I got the final diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 576381)
Time Spent: 40m (was: 0.5h)
> Describe table partition fetch should be configurable
> -----------------------------------------------------
>
> Key: HIVE-24965
> URL: https://issues.apache.org/jira/browse/HIVE-24965
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 3.0.0, 3.1.1, 3.1.2
> Reporter: Kevin Cheung
> Assignee: Kevin Cheung
> Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In certain 3rd party hive UIs, they issue a describe table command, and
> usually it's either "describe formatted table" or "describe extended table",
> and it will take a very long time for highly partitioned tables (10k+). In
> the UI, there is no way to change the settings (to use "describe table"),
> thus impairing the user experience. Prior to the feature where partition
> stats was gathered, the experience with using the UI had no problems.
> This will allow users to selectively change the describe formatted/extended
> table behavior at any time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
