[
https://issues.apache.org/jira/browse/HIVE-24918?focusedWorklogId=573857&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-573857
]
ASF GitHub Bot logged work on HIVE-24918:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/21 03:09
Start Date: 30/Mar/21 03:09
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2097:
URL: https://github.com/apache/hive/pull/2097#discussion_r603748637
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -414,7 +441,8 @@ private boolean shouldDump(Path previousDumpPath) throws
IOException {
return true;
} else {
FileSystem fs = previousDumpPath.getFileSystem(conf);
- return fs.exists(new Path(previousDumpPath,
LOAD_ACKNOWLEDGEMENT.toString()));
+ return fs.exists(new Path(previousDumpPath,
LOAD_ACKNOWLEDGEMENT.toString()))
+ && !fs.exists(new Path(previousDumpPath,
FAILOVER_READY_MARKER.toString()));
Review comment:
If the skip is because of failover, we should also also ensure if there
is no open write txn at this point of time and if found one, we should fail the
policy with irrecoverable error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 573857)
Time Spent: 50m (was: 40m)
> Handle failover case during Repl Dump
> -------------------------------------
>
> Key: HIVE-24918
> URL: https://issues.apache.org/jira/browse/HIVE-24918
> Project: Hive
> Issue Type: New Feature
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> To handle:
> a) Whenever user wants to go ahead with failover, during the next or
> subsequent repl dump operation upon confirming that there are no pending open
> transaction events, in should create a _failover_ready marker file in the
> dump dir.
> b) Skip next repl dump instances once we have the marker file placed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
