[
https://issues.apache.org/jira/browse/HIVE-24852?focusedWorklogId=571225&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-571225
]
ASF GitHub Bot logged work on HIVE-24852:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/21 15:14
Start Date: 24/Mar/21 15:14
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #2043:
URL: https://github.com/apache/hive/pull/2043#discussion_r600578957
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/DirCopyTask.java
##########
@@ -162,14 +165,21 @@ public int execute() {
// do we create a new conf and only here provide this additional
option so that we get away from
// differences of data in two location for the same directories ?
// basically add distcp.options.delete to hiveconf new object ?
- FileUtils.distCp(
- sourcePath.getFileSystem(conf), // source file system
- Collections.singletonList(sourcePath), // list of source paths
- targetPath,
- false,
- proxyUser,
- conf,
- ShimLoader.getHadoopShims());
+ if (!getWork().getCopyMode()
+ .equals(SnapshotUtils.SnapshotCopyMode.FALLBACK_COPY)) {
+ LOG.info("Using Snapshot mode of copy for source: {} and target:"
+ + " {}", sourcePath, targetPath);
+ copyUsingDistCpSnapshots(sourcePath, targetPath, proxyUser);
+ // Use distcp with snapshots for copy.
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 571225)
Time Spent: 1h 40m (was: 1.5h)
> Add support for Snapshots during external table replication
> -----------------------------------------------------------
>
> Key: HIVE-24852
> URL: https://issues.apache.org/jira/browse/HIVE-24852
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Critical
> Labels: pull-request-available
> Attachments: Design Doc HDFS Snapshots for External Table
> Replication-01.pdf
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Add support for use of snapshot diff for external table replication.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
