[
https://issues.apache.org/jira/browse/HIVE-24900?focusedWorklogId=570584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570584
]
ASF GitHub Bot logged work on HIVE-24900:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/21 15:56
Start Date: 23/Mar/21 15:56
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2086:
URL: https://github.com/apache/hive/pull/2086#discussion_r599703002
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -553,8 +563,18 @@ protected Boolean findNextCompactionAndExecute(boolean
computeStats) throws Inte
compactionTxn.wasSuccessful();
} catch (Throwable e) {
LOG.error("Caught exception while trying to compact " + ci +
- ". Marking failed to avoid repeated failures", e);
+ ". Deleting the result directories created by the compactor "+
resultDir +
+ " Marking failed to avoid repeated failures", e);
markFailed(ci, e);
+ // remove the new directories created by compaction
+ if (resultDir != null) {
Review comment:
FS operations should be wrapped with doAs:
```
if (runJobAsSelf(ci.runAs)) {
CLEANUP()
} else {
UserGroupInformation ugi =
UserGroupInformation.createProxyUser(ci.runAs,UserGroupInformation.getLoginUser());
ugi.doAs((PrivilegedExceptionAction<Object>) () -> CLEANUP() });
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 570584)
Time Spent: 2h 20m (was: 2h 10m)
> Failed compaction does not cleanup the directories
> --------------------------------------------------
>
> Key: HIVE-24900
> URL: https://issues.apache.org/jira/browse/HIVE-24900
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: Ramesh Kumar Thangarajan
> Assignee: Ramesh Kumar Thangarajan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Failed compaction does not cleanup the directories
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
