[ https://issues.apache.org/jira/browse/HIVE-24315?focusedWorklogId=568990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568990 ]
ASF GitHub Bot logged work on HIVE-24315: ----------------------------------------- Author: ASF GitHub Bot Created on: 19/Mar/21 16:08 Start Date: 19/Mar/21 16:08 Worklog Time Spent: 10m Work Description: zeroflag commented on a change in pull request #2059: URL: https://github.com/apache/hive/pull/2059#discussion_r597801336 ########## File path: hplsql/src/main/java/org/apache/hive/hplsql/UndefinedException.java ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hive.hplsql; + +import org.antlr.v4.runtime.ParserRuleContext; + +public class UndefinedException extends HplValidationException { Review comment: Ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 568990) Time Spent: 1h (was: 50m) > Improve validation and error handling in HPL/SQL > ------------------------------------------------- > > Key: HIVE-24315 > URL: https://issues.apache.org/jira/browse/HIVE-24315 > Project: Hive > Issue Type: Sub-task > Components: hpl/sql > Reporter: Attila Magyar > Assignee: Attila Magyar > Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > There are some known issues that need to be fixed. For example it seems that > arity of a function is not checked when calling it, and same is true for > parameter types. Calling an undefined function is evaluated to null and > sometimes it seems that incorrect syntax is silently ignored. > In cases like this a helpful error message would be expected, thought we > should also consider how PL/SQL works and maintain compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)