[ 
https://issues.apache.org/jira/browse/HIVE-24828?focusedWorklogId=568022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568022
 ]

ASF GitHub Bot logged work on HIVE-24828:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Mar/21 00:01
            Start Date: 18/Mar/21 00:01
    Worklog Time Spent: 10m 
      Work Description: hsnusonic commented on a change in pull request #2073:
URL: https://github.com/apache/hive/pull/2073#discussion_r596462319



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -3585,6 +3532,77 @@ public ShowCompactResponse 
showCompact(ShowCompactRequest rqst) throws MetaExcep
     }
   }
 
+  @RetrySemantics.ReadOnly
+  public GetLatestCompactionResponse 
getLatestCompaction(GetLatestCompactionRequest rqst) throws MetaException {
+    GetLatestCompactionResponse response = new GetLatestCompactionResponse();
+    response.setDbname(rqst.getDbname());
+    response.setTablename(rqst.getTablename());
+    Connection dbConn = null;
+    PreparedStatement pst = null;
+    try {

Review comment:
       In the latest change, I closed the connection, statement, resultset in 
the finally block as some other methods in this file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 568022)
    Time Spent: 2h 40m  (was: 2.5h)

> [HMS] Provide new HMS API to return latest committed compaction record for a 
> given table
> ----------------------------------------------------------------------------------------
>
>                 Key: HIVE-24828
>                 URL: https://issues.apache.org/jira/browse/HIVE-24828
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HiveServer2
>            Reporter: Kishen Das
>            Assignee: Yu-Wen Lai
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> We need a new HMS API to return the latest committed compaction record for a 
> given table. This can be used by a remote cache to decide whether a given 
> table's file metadata has been compacted or not, in order to decide whether 
> file metadata has to be refreshed from the file system before serving or it 
> can serve the current data from the cache. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to