[
https://issues.apache.org/jira/browse/HIVE-24874?focusedWorklogId=567019&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-567019
]
ASF GitHub Bot logged work on HIVE-24874:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Mar/21 15:06
Start Date: 16/Mar/21 15:06
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2062:
URL: https://github.com/apache/hive/pull/2062#discussion_r595260109
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -97,12 +99,14 @@ public static String hostname() {
public void run() {
LOG.info("Starting Worker thread");
boolean computeStats =
conf.getBoolVar(HiveConf.ConfVars.HIVE_MR_COMPACTOR_GATHER_STATS);
+ boolean metricsEnabled =
conf.getBoolVar(HiveConf.ConfVars.HIVE_SERVER2_METRICS_ENABLED);
Review comment:
fixed
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -390,9 +392,12 @@ private ExecutorService getTimeoutHandlingExecutor() {
* @throws InterruptedException is thrown when the process is interrupted
because of timeout for example
*/
@VisibleForTesting
- protected Boolean findNextCompactionAndExecute(boolean computeStats) throws
InterruptedException {
+ protected Boolean findNextCompactionAndExecute(boolean computeStats) {
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 567019)
Time Spent: 0.5h (was: 20m)
> Worker performance metric
> -------------------------
>
> Key: HIVE-24874
> URL: https://issues.apache.org/jira/browse/HIVE-24874
> Project: Hive
> Issue Type: Sub-task
> Reporter: Denys Kuzmenko
> Assignee: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Wrap Compaction Worker with PerformanceLogger.
> Major and Minor compactions should be measured to separate metrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
