[
https://issues.apache.org/jira/browse/HIVE-24867?focusedWorklogId=564649&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-564649
]
ASF GitHub Bot logged work on HIVE-24867:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/21 14:55
Start Date: 11/Mar/21 14:55
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2058:
URL: https://github.com/apache/hive/pull/2058#discussion_r592428189
##########
File path:
iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergFilterFactory.java
##########
@@ -230,7 +231,8 @@ public void testDateType() {
public void testTimestampType() {
Literal<Long> timestampLiteral =
Literal.of("2012-10-02T05:16:17.123456").to(Types.TimestampType.withoutZone());
long timestampMicros = timestampLiteral.value();
- Timestamp ts =
Timestamp.valueOf(DateTimeUtil.timestampFromMicros(timestampMicros));
+ //
`org.apache.hadoop.hive.common.type.Timestamp.valueOf(lit.toString()).toSqlTimestamp()`
+ Timestamp ts =
Timestamp.from(DateTimeUtil.timestampFromMicros(timestampMicros).toInstant(ZoneOffset.UTC));
Review comment:
Removed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 564649)
Time Spent: 2h 20m (was: 2h 10m)
> Create iceberg-handler module in Hive
> -------------------------------------
>
> Key: HIVE-24867
> URL: https://issues.apache.org/jira/browse/HIVE-24867
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> * Create a new iceberg-handler module in Hive
> * Copy the code from the Iceberg/iceberg-mr module into this new Hive module
> * Make necessary changes so it compiles with Hive 4.0.0 dependencies
> (iceberg-mr code was based on Hive 3.1)
> * Make sure all tests pass
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
