[
https://issues.apache.org/jira/browse/HIVE-24871?focusedWorklogId=564544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-564544
]
ASF GitHub Bot logged work on HIVE-24871:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/21 11:56
Start Date: 11/Mar/21 11:56
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2061:
URL: https://github.com/apache/hive/pull/2061#discussion_r592299917
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -171,9 +176,12 @@ public void run() {
StringUtils.stringifyException(t));
}
finally {
- if(handle != null) {
+ if (handle != null) {
handle.releaseLocks();
}
+ if (metricsEnabled) {
Review comment:
checked: it won't fail and won't report metric in this case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 564544)
Time Spent: 40m (was: 0.5h)
> Initiator / Cleaner performance metrics
> ---------------------------------------
>
> Key: HIVE-24871
> URL: https://issues.apache.org/jira/browse/HIVE-24871
> Project: Hive
> Issue Type: Sub-task
> Reporter: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The PerformanceLogger should be used in Initiator and Cleaner service.
> * One cycle of Initiator should be measured, with ignoring the time spent
> waiting on the lock for AUX table
> * One compaction cleanup should be measured in Cleaner (using different
> metric for major and minor compaction cleanup)
> Important note: the PerformanceLogger implementation from metastore should be
> used (not the ql one) otherwise the metric won't be published in HMS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
