[ https://issues.apache.org/jira/browse/HIVE-24865?focusedWorklogId=564293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-564293 ]
ASF GitHub Bot logged work on HIVE-24865: ----------------------------------------- Author: ASF GitHub Bot Created on: 11/Mar/21 04:32 Start Date: 11/Mar/21 04:32 Worklog Time Spent: 10m Work Description: kasakrisz commented on a change in pull request #2060: URL: https://github.com/apache/hive/pull/2060#discussion_r592059837 ########## File path: parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexerParent.g ########## @@ -376,6 +376,8 @@ KW_PKFK_JOIN: 'PKFK_JOIN'; KW_LEADING: 'LEADING'; KW_TRAILING: 'TRAILING'; KW_TRIM: 'TRIM'; +KW_IGNORE: 'IGNORE'; Review comment: These are non-reserved keywords: added `Respect` to the list, `Ignore` was already there but it was not defined in the lexer before this patch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 564293) Time Spent: 1h (was: 50m) > Implement Respect/Ignore Nulls in first/last_value > -------------------------------------------------- > > Key: HIVE-24865 > URL: https://issues.apache.org/jira/browse/HIVE-24865 > Project: Hive > Issue Type: New Feature > Components: Parser, UDF > Reporter: Krisztian Kasa > Assignee: Krisztian Kasa > Priority: Minor > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > {code:java} > <null treatment> ::= > RESPECT NULLS | IGNORE NULLS > <first or last value function> ::= > <first or last value> <left paren> <value expression> <right paren> [ <null > treatment> > ] > <first or last value> ::= > FIRST_VALUE | LAST_VALUE > {code} > Example: > {code:java} > select last_value(b) ignore nulls over(partition by a order by b) from t1; > {code} > Existing non-standard implementation: > {code:java} > select last_value(b, true) over(partition by a order by b) from t1; > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)