[
https://issues.apache.org/jira/browse/HIVE-24853?focusedWorklogId=563828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-563828
]
ASF GitHub Bot logged work on HIVE-24853:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/21 15:31
Start Date: 10/Mar/21 15:31
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #2044:
URL: https://github.com/apache/hive/pull/2044#discussion_r591622476
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
##########
@@ -1783,12 +1783,18 @@ private long partsFoundForPartitions(
MetastoreDirectSqlUtils.timingTrace(doTrace, queryText, start, end);
List<Object[]> list = MetastoreDirectSqlUtils.ensureList(qResult);
List<ColumnStatisticsObj> colStats = new
ArrayList<ColumnStatisticsObj>(list.size());
- for (Object[] row : list) {
- colStats.add(prepareCSObjWithAdjustedNDV(row, 0,
useDensityFunctionForNDVEstimation, ndvTuner));
- Deadline.checkTimeout();
+ for (Object[] row : list) {
+ colStats.add(prepareCSObjWithAdjustedNDV(row, 0,
+ useDensityFunctionForNDVEstimation, ndvTuner));
+ Deadline.checkTimeout();
+ }
+ return colStats;
+ } catch (Exception e) {
Review comment:
wouldn't this will swallow some exception types?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 563828)
Time Spent: 1.5h (was: 1h 20m)
> HMS leaks queries in case of timeout
> ------------------------------------
>
> Key: HIVE-24853
> URL: https://issues.apache.org/jira/browse/HIVE-24853
> Project: Hive
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The queries aren't closed in case of timeout.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
