[
https://issues.apache.org/jira/browse/HIVE-24824?focusedWorklogId=563173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-563173
]
ASF GitHub Bot logged work on HIVE-24824:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/21 16:13
Start Date: 09/Mar/21 16:13
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #2016:
URL: https://github.com/apache/hive/pull/2016#discussion_r590507504
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestInitiator.java
##########
@@ -865,7 +865,7 @@ public void processCompactionCandidatesInParallel() throws
Exception {
}
@Test
- public void testInitiatorMetricsEnabled() throws Exception {
+ public void testAcidMetricsEnabled() throws Exception {
Review comment:
I think these tests test the AcidMetricsService more than Initiator, so
they should be in TestAcidMetricsService
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 563173)
Time Spent: 1h (was: 50m)
> Define metrics for compaction observability
> -------------------------------------------
>
> Key: HIVE-24824
> URL: https://issues.apache.org/jira/browse/HIVE-24824
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Many times if there are failures in the Compaction background processes
> (Initiator, Worker, Cleaner) it is hard notice the problem until it causes
> serious performance degradation.
> We should create new JMX metrics, that would make it easier to monitor the
> compaction health. Examples are:
> * number of failed / initiated compaction
> * number of aborted txns, oldest aborted txns
> * tables with disabled compactions and writes
> * Initiator and Cleaner cycle runtime
> * Size of ACID metadata tables that should have ~ constant rows
> (txn_to_writeId, completed_txns)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
