[
https://issues.apache.org/jira/browse/HIVE-24817?focusedWorklogId=563071&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-563071
]
ASF GitHub Bot logged work on HIVE-24817:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/21 13:54
Start Date: 09/Mar/21 13:54
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #2027:
URL: https://github.com/apache/hive/pull/2027#discussion_r590387847
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/type/TypeCheckProcFactory.java
##########
@@ -1007,17 +1001,12 @@ protected T getXpathOrFuncExprNodeDesc(ASTNode node,
T columnDesc = children.get(0);
T valueDesc = interpretNode(columnDesc, children.get(i));
if (valueDesc == null) {
- if (hasNullValue) {
- // Skip if null value has already been added
- continue;
- }
- TypeInfo targetType = exprFactory.getTypeInfo(columnDesc);
+ // Keep original
+ TypeInfo targetType = exprFactory.getTypeInfo(children.get(i));
if (!expressions.containsKey(targetType)) {
expressions.put(targetType, columnDesc);
}
- T nullConst = exprFactory.createConstantExpr(targetType, null);
- expressions.put(targetType, nullConst);
- hasNullValue = true;
+ expressions.put(targetType, children.get(i));
} else {
Review comment:
yes they could be in Calcite some day...we can live without them
that if statement is easier to be viewed without all these comments:
https://github.com/apache/hive/blob/20137b5894fc7ec6f4acaef4304dfdc2ce93275a/ql/src/java/org/apache/hadoop/hive/ql/parse/type/TypeCheckProcFactory.java#L1012-L1015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 563071)
Time Spent: 50m (was: 40m)
> "not in" clause returns incorrect data when there is coercion
> -------------------------------------------------------------
>
> Key: HIVE-24817
> URL: https://issues.apache.org/jira/browse/HIVE-24817
> Project: Hive
> Issue Type: Bug
> Components: CBO
> Reporter: Steve Carlin
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When the query has a where clause that has an integer column checking against
> being "not in" a decimal column, the decimal column is being changed to null,
> causing incorrect results.
> This is a sample query of a failure:
> select count(*) from my_tbl where int_col not in (355.8);
> Since the int_col can never be 355.8, one would expect all the rows to be
> returned, but it is changing the 355.8 into a null value causing no rows to
> be returned.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
