[
https://issues.apache.org/jira/browse/HIVE-24834?focusedWorklogId=558480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558480
]
ASF GitHub Bot logged work on HIVE-24834:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/21 10:03
Start Date: 26/Feb/21 10:03
Worklog Time Spent: 10m
Work Description: ChangjiGuo commented on a change in pull request #2024:
URL: https://github.com/apache/hive/pull/2024#discussion_r583522422
##########
File path:
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreUtils.java
##########
@@ -201,7 +201,7 @@ static public Deserializer getDeserializer(Configuration
conf,
private static final String FROM_SERIALIZER = "from deserializer";
private static String determineFieldComment(String comment) {
- return (comment == null) ? FROM_SERIALIZER : comment;
+ return ("".equals(comment)) ? null : comment;
Review comment:
I think we should not specify a value if the comment is null, so I
modified the unit test.
Is my understanding right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 558480)
Time Spent: 20m (was: 10m)
> Cannot add comment for kafka table
> ----------------------------------
>
> Key: HIVE-24834
> URL: https://issues.apache.org/jira/browse/HIVE-24834
> Project: Hive
> Issue Type: Bug
> Components: kafka integration
> Affects Versions: 2.3.7
> Reporter: ChangjiGuo
> Assignee: ChangjiGuo
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> when using kafka-handler to create a kafka table, no matter whether the user
> specifies column comment or not, the comment will become 'from deserializer'
> when the 'show create table' command is used to view the table structure.
> You can refer to the following example:
> {code:sql}
> CREATE EXTERNAL TABLE `kafka_table`(
> `id` string,
> `info` string comment 'comment 1',
> `jsoninfo` struct<id:string,info:string> comment 'comment 2')
> ROW FORMAT SERDE
> 'org.apache.hadoop.hive.kafka.KafkaSerDe'
> STORED BY
> 'org.apache.hadoop.hive.kafka.KafkaStorageHandler'
> WITH SERDEPROPERTIES (
> 'serialization.format'='1')
> LOCATION
> 'hdfs://offlinehdfs/user/hive/warehouse/kafka_table'
> TBLPROPERTIES (
> 'properties.bootstrap.servers'='xxxx',
> 'topic'='xxxx'
> ..........)
> {code}
> The result is as follows:
> {code:sql}
> CREATE EXTERNAL TABLE `kafka_table`(
> `id` string COMMENT 'from deserializer',
> `info` string COMMENT 'from deserializer',
> `jsoninfo` struct<id:string,info:string> COMMENT 'from deserializer',
> `__key` binary COMMENT 'from deserializer',
> `__partition` int COMMENT 'from deserializer',
> `__offset` bigint COMMENT 'from deserializer',
> `__timestamp` bigint COMMENT 'from deserializer')
> ROW FORMAT SERDE
> 'org.apache.hadoop.hive.kafka.KafkaSerDe'
> STORED BY
> 'org.apache.hadoop.hive.kafka.KafkaStorageHandler'
> WITH SERDEPROPERTIES (
> 'serialization.format'='1')
> LOCATION
> 'hdfs://offlinehdfs/user/hive/warehouse/kafka_table'
> TBLPROPERTIES (
> .......)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
