[ 
https://issues.apache.org/jira/browse/HIVE-24445?focusedWorklogId=557904&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-557904
 ]

ASF GitHub Bot logged work on HIVE-24445:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Feb/21 13:20
            Start Date: 25/Feb/21 13:20
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on a change in pull request #2020:
URL: https://github.com/apache/hive/pull/2020#discussion_r582821814



##########
File path: 
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -585,8 +585,8 @@ struct Table {
   22: optional byte accessType,
   23: optional list<string> requiredReadCapabilities,
   24: optional list<string> requiredWriteCapabilities
-  25: optional i64 id,                 // id of the table. It will be ignored 
if set. It's only for
-                                        // read purposed
+  25: optional i64 id,                 // id of the table. It will be ignored 
if set. It's only for read purposed

Review comment:
       nit: didn't this should be `purposes`?

##########
File path: 
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -585,8 +585,8 @@ struct Table {
   22: optional byte accessType,
   23: optional list<string> requiredReadCapabilities,
   24: optional list<string> requiredWriteCapabilities
-  25: optional i64 id,                 // id of the table. It will be ignored 
if set. It's only for
-                                        // read purposed
+  25: optional i64 id,                 // id of the table. It will be ignored 
if set. It's only for read purposed
+  26: optional i64 txnid,

Review comment:
       this interface seems to follow `camelCase` naming - I think this field 
should be named `txnId`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 557904)
    Time Spent: 1h 40m  (was: 1.5h)

> Non blocking DROP table implementation
> --------------------------------------
>
>                 Key: HIVE-24445
>                 URL: https://issues.apache.org/jira/browse/HIVE-24445
>             Project: Hive
>          Issue Type: New Feature
>          Components: Hive
>            Reporter: Zoltan Chovan
>            Assignee: Zoltan Chovan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Implement a way to execute drop table operations in a way that doesn't have 
> to wait for currently running read operations to be finished.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to