[
https://issues.apache.org/jira/browse/HIVE-24753?focusedWorklogId=557767&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-557767
]
ASF GitHub Bot logged work on HIVE-24753:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/21 07:36
Start Date: 25/Feb/21 07:36
Worklog Time Spent: 10m
Work Description: pvargacl commented on a change in pull request #2017:
URL: https://github.com/apache/hive/pull/2017#discussion_r582603575
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/AcidEventListener.java
##########
@@ -72,6 +77,22 @@ public void onDropPartition(DropPartitionEvent
partitionEvent) throws MetaExcep
txnHandler = getTxnHandler();
txnHandler.cleanupRecords(HiveObjectType.PARTITION, null,
partitionEvent.getTable(),
partitionEvent.getPartitionIterator());
+
+ if (MetastoreConf.getBoolVar(conf, ConfVars.LOCKLESS_READS_ENABLED)) {
+ CompactionRequest rqst = new
CompactionRequest(partitionEvent.getTable().getDbName(),
partitionEvent.getTable().getTableName(),
Review comment:
Is this going to work? If the partition record is dropped, I think the
compaction will automatically fail, there should be a test for this
I think you should just create a compaction record that is in
ready_for_cleaning state. And since there is a base file, I think I would
prefer a major compaction, but it does not really matter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 557767)
Time Spent: 40m (was: 0.5h)
> Non blocking DROP PARTITION implementation
> ------------------------------------------
>
> Key: HIVE-24753
> URL: https://issues.apache.org/jira/browse/HIVE-24753
> Project: Hive
> Issue Type: New Feature
> Reporter: Zoltan Chovan
> Assignee: Zoltan Chovan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Implement a way to execute drop partition operations in a way that doesn't
> have to wait for currently running read operations to be finished.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
