[jira] [Work logged] (HIVE-24624) Repl Load should detect the compatible staging dir

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-24624?focusedWorklogId=550577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550577
 ]

ASF GitHub Bot logged work on HIVE-24624:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Feb/21 05:46
            Start Date: 10/Feb/21 05:46
    Worklog Time Spent: 10m 
      Work Description: aasha commented on a change in pull request #1855:
URL: https://github.com/apache/hive/pull/1855#discussion_r573464291



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java
##########
@@ -398,11 +398,8 @@ private Path getCurrentLoadPath() throws IOException, 
SemanticException {
   }
 
   private boolean shouldLoadProceed (Path hiveDumpPath) throws IOException {
-    if (hiveDumpPath != null) { // Is null check necessary?
-      return hiveDumpPath.getFileSystem(conf).exists(new Path(hiveDumpPath, 
ReplAck.DUMP_ACKNOWLEDGEMENT.toString()))
-          && !hiveDumpPath.getFileSystem(conf).exists(new Path(hiveDumpPath, 
LOAD_ACKNOWLEDGEMENT.toString()));
-    }
-    return false;
+    return hiveDumpPath.getFileSystem(conf).exists(new Path(hiveDumpPath, 
ReplAck.DUMP_ACKNOWLEDGEMENT.toString()))

Review comment:
       better to keep the check. If someone reuses the method, might lead to npe




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 550577)
    Time Spent: 1h 20m  (was: 1h 10m)

> Repl Load should detect the compatible staging dir
> --------------------------------------------------
>
>                 Key: HIVE-24624
>                 URL: https://issues.apache.org/jira/browse/HIVE-24624
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Pratyushotpal Madhukar
>            Assignee: Pratyushotpal Madhukar
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-24624.patch
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Repl load in CDP when pointed to a staging dir should be able to detect 
> whether the staging dir has the dump structure in compatible format or not



--
This message was sent by Atlassian Jira
(v8.3.4#803005)