[
https://issues.apache.org/jira/browse/HIVE-24707?focusedWorklogId=547167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-547167
]
ASF GitHub Bot logged work on HIVE-24707:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/21 17:51
Start Date: 03/Feb/21 17:51
Worklog Time Spent: 10m
Work Description: pgaref edited a comment on pull request #1933:
URL: https://github.com/apache/hive/pull/1933#issuecomment-772699104
> @pgaref If only you hadn't asked me to look one more time I probably would
have just merged. :)
Np at all @belugabehr -- thats what reviews are for :)
Updated PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 547167)
Time Spent: 3h 40m (was: 3.5h)
> Apply Sane Default for Tez Containers as Last Resort
> ----------------------------------------------------
>
> Key: HIVE-24707
> URL: https://issues.apache.org/jira/browse/HIVE-24707
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: Panagiotis Garefalakis
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> {code:java|title=DagUtils.java}
> public static Resource getContainerResource(Configuration conf) {
> int memory = HiveConf.getIntVar(conf,
> HiveConf.ConfVars.HIVETEZCONTAINERSIZE) > 0 ?
> HiveConf.getIntVar(conf, HiveConf.ConfVars.HIVETEZCONTAINERSIZE) :
> conf.getInt(MRJobConfig.MAP_MEMORY_MB,
> MRJobConfig.DEFAULT_MAP_MEMORY_MB);
> int cpus = HiveConf.getIntVar(conf, HiveConf.ConfVars.HIVETEZCPUVCORES) >
> 0 ?
> HiveConf.getIntVar(conf, HiveConf.ConfVars.HIVETEZCPUVCORES) :
> conf.getInt(MRJobConfig.MAP_CPU_VCORES,
> MRJobConfig.DEFAULT_MAP_CPU_VCORES);
> return Resource.newInstance(memory, cpus);
> }
> {code}
> If Tez Container Size or VCores is an invalid value ( <= 0 ) then it falls
> back onto the MapReduce configurations, but if the MapReduce configurations
> have invalid values ( <= 0 ), they are excepted regardless and this will
> cause failures down the road.
> This code should also check the MapReduce values and fall back to MapReduce
> default values if they are <= 0.
> Also, some logging would be nice here too, reporting about where the
> configuration values came from.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
