[ 
https://issues.apache.org/jira/browse/HIVE-24701?focusedWorklogId=547135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-547135
 ]

ASF GitHub Bot logged work on HIVE-24701:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Feb/21 17:12
            Start Date: 03/Feb/21 17:12
    Worklog Time Spent: 10m 
      Work Description: belugabehr commented on pull request #1927:
URL: https://github.com/apache/hive/pull/1927#issuecomment-772672233


   ```none
   Testing / split-14 / PostProcess / testVectorUDFUnixTimeStamp – 
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorDateExpressions
   2s
   Stacktrace
   java.lang.AssertionError: expected:<97848024390000> but was:<-97972298294822>
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
   ```
   
   This issue is fixed in #1938 so should pass after #1938 is merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 547135)
    Time Spent: 0.5h  (was: 20m)

> Remove String Manipulation from Date Parsing TimestampTZUtil
> ------------------------------------------------------------
>
>                 Key: HIVE-24701
>                 URL: https://issues.apache.org/jira/browse/HIVE-24701
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This operation is pretty slow:
> {code:java}
>   // Converts Date to TimestampTZ.
>   public static TimestampTZ convert(Date date, ZoneId defaultTimeZone) {
>     return parse(date.toString(), defaultTimeZone);
>   }
> {code}
> To convert from Date to TimestampTZ, it creates a string, then parses it.  
> Should be able to just look at the epoch time and do the conversion without 
> all the string manipulation/parsing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to