[ 
https://issues.apache.org/jira/browse/HIVE-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945281#comment-14945281
 ] 

Sergio Peña commented on HIVE-12038:
------------------------------------

Thanks [~szehon]
I reviewed, and the patch looks good.
+1

> Fix the 'overall' section in the HiveQA report
> ----------------------------------------------
>
>                 Key: HIVE-12038
>                 URL: https://issues.apache.org/jira/browse/HIVE-12038
>             Project: Hive
>          Issue Type: Improvement
>          Components: Testing Infrastructure
>            Reporter: Szehon Ho
>            Assignee: Szehon Ho
>            Priority: Minor
>         Attachments: HIVE-12038.patch
>
>
> HIVE-11913 added a new review to HiveQA that checks for added unit tests, 
> however this is not reflected in the 'Overall' review at the top of the JIRA 
> comment.  Example below:
> {color:red}Overall{color}: -1 at least one tests failed
> Here are the results of testing the latest attachment:
> https://issues.apache.org/jira/secure/attachment/12764994/HIVE-11976.03.patch
> {color:red}ERROR:{color} -1 due to no test(s) being added or modified.
> {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 9645 tests 
> executed
> *Failed tests:*
> {noformat}
> org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
> {noformat}
> Test results: 
> http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5534/testReport
> Console output: 
> http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5534/console
> Test logs: 
> http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5534/
> Messages:
> {noformat}
> Executing org.apache.hive.ptest.execution.TestCheckPhase
> Executing org.apache.hive.ptest.execution.PrepPhase
> Executing org.apache.hive.ptest.execution.ExecutionPhase
> Executing org.apache.hive.ptest.execution.ReportingPhase
> Tests exited with: TestsFailedException: 1 tests failed
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to