[
https://issues.apache.org/jira/browse/HIVE-23458?focusedWorklogId=546759&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-546759
]
ASF GitHub Bot logged work on HIVE-23458:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/21 01:35
Start Date: 03/Feb/21 01:35
Worklog Time Spent: 10m
Work Description: EugeneChung commented on a change in pull request #1919:
URL: https://github.com/apache/hive/pull/1919#discussion_r568842878
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -746,6 +746,8 @@ private static void populateLlapDaemonVarsSet(Set<String>
llapDaemonVarsSetLocal
"This value must not contain any special character used in HDFS URI
(e.g., ':', '%', '/' etc). \n" +
"The user has to be aware that the dynamic partition value should not
contain this value to avoid confusions."),
DEFAULT_ZOOKEEPER_PARTITION_NAME("hive.lockmgr.zookeeper.default.partition.name",
"__HIVE_DEFAULT_ZOOKEEPER_PARTITION__", ""),
+ HIVE_EXEC_SCHEDULED_POOL_NUM_THREADS("hive.exec.scheduler.num.threads", 10,
Review comment:
Yes, the role of corepoolsize is exactly what you understand.
The reason I set to 10 is just because `metastore.thread.pool.size` is 10. I
think 2 would be good.
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -746,6 +746,8 @@ private static void populateLlapDaemonVarsSet(Set<String>
llapDaemonVarsSetLocal
"This value must not contain any special character used in HDFS URI
(e.g., ':', '%', '/' etc). \n" +
"The user has to be aware that the dynamic partition value should not
contain this value to avoid confusions."),
DEFAULT_ZOOKEEPER_PARTITION_NAME("hive.lockmgr.zookeeper.default.partition.name",
"__HIVE_DEFAULT_ZOOKEEPER_PARTITION__", ""),
+ HIVE_EXEC_SCHEDULED_POOL_NUM_THREADS("hive.exec.scheduler.num.threads", 10,
Review comment:
https://github.com/EugeneChung/hive/commit/ccf6ed68b62cfe71a9014abd4e58cb7eeac44d44
I set it to 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 546759)
Time Spent: 1h (was: 50m)
> Introduce unified thread pool for scheduled jobs
> ------------------------------------------------
>
> Key: HIVE-23458
> URL: https://issues.apache.org/jira/browse/HIVE-23458
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: Eugene Chung
> Assignee: Eugene Chung
> Priority: Major
> Labels: pull-request-available, todoc4.0
> Fix For: 4.0.0
>
> Attachments: HIVE-23458.01.patch, HIVE-23458.02.patch,
> HIVE-23458.03.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> As I mentioned in [the comment of
> HIVE-23164|https://issues.apache.org/jira/browse/HIVE-23164?focusedCommentId=17089506&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17089506],
> I've made the unified scheduled executor service like
> org.apache.hadoop.hive.metastore.ThreadPool.
> I think it could help
> 1. to minimize the possibility of making non-daemon threads when developers
> need ScheduledExecutorService
> 2. to achieve the utilization of server resources because the current
> situation is all of the modules make its own ScheduledExecutorService and all
> of the threads are just using for one job.
> 3. administrators of Hive servers by providing
> hive.exec.scheduler.num.threads configuration so that they can predict and
> set how many threads are used and needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
