[ 
https://issues.apache.org/jira/browse/HIVE-24353?focusedWorklogId=543792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543792
 ]

ASF GitHub Bot logged work on HIVE-24353:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Jan/21 18:36
            Start Date: 28/Jan/21 18:36
    Worklog Time Spent: 10m 
      Work Description: belugabehr commented on pull request #1650:
URL: https://github.com/apache/hive/pull/1650#issuecomment-769290043


   Lemme take a look.  @abstractdog as it relates to HIVE-24693, this is not 
necessary, as HIVE-24693 removes this parsing from the code path altogether.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 543792)
    Time Spent: 1h 10m  (was: 1h)

> performance: Refactor TimestampTZ parsing
> -----------------------------------------
>
>                 Key: HIVE-24353
>                 URL: https://issues.apache.org/jira/browse/HIVE-24353
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Vincenz Priesnitz
>            Assignee: Vincenz Priesnitz
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> I found that for datasets that contain a lot of timestamps (without 
> timezones) hive spends the majority of time in TimestampTZUtil.parse, in 
> particular constructing stractraces for the try-catch blocks. 
> When parsing TimestampTZ we are currently using a fallback chain with several 
> try-catch blocks. For a common timestamp string without a timezone, we 
> currently throw and catch 2 exceptions, and actually parse the string twice. 
> I propose a refactor, that parses the string once and then expresses the 
> fallback chain with queries to the parsed TemporalAccessor. 
>  
> Update: I added a PR that resolves this issue: 
> [https://github.com/apache/hive/pull/1650] 
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to