[ https://issues.apache.org/jira/browse/HIVE-24694?focusedWorklogId=543566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543566 ]
ASF GitHub Bot logged work on HIVE-24694: ----------------------------------------- Author: ASF GitHub Bot Created on: 28/Jan/21 10:56 Start Date: 28/Jan/21 10:56 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on a change in pull request #1920: URL: https://github.com/apache/hive/pull/1920#discussion_r566000251 ########## File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ########## @@ -357,6 +357,15 @@ public HiveConnection(String uri, Properties info) throws SQLException { } if (numRetries >= maxRetries) { + try { Review comment: yes, you're right. Thanks very much for the advice and comments! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 543566) Time Spent: 40m (was: 0.5h) > Early connection close to release server resources during creating > ------------------------------------------------------------------ > > Key: HIVE-24694 > URL: https://issues.apache.org/jira/browse/HIVE-24694 > Project: Hive > Issue Type: Bug > Components: HiveServer2 > Reporter: Zhihua Deng > Assignee: Zhihua Deng > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > If exception happens during we try to get the connection from HiveDriver, > the opened transport or session may leave unclosed as the connection returned > is null, we cannot call the close method to release the server > resources(threads, connection quota, etc.), this could make things more worse > if the user rearches the connection limit and retries... -- This message was sent by Atlassian Jira (v8.3.4#803005)