[
https://issues.apache.org/jira/browse/HIVE-24678?focusedWorklogId=543382&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543382
]
ASF GitHub Bot logged work on HIVE-24678:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/21 05:17
Start Date: 28/Jan/21 05:17
Worklog Time Spent: 10m
Work Description: kasakrisz commented on a change in pull request #1912:
URL: https://github.com/apache/hive/pull/1912#discussion_r565825995
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
##########
@@ -1791,9 +1792,16 @@ private static boolean validPreConditions(ParseContext
pctx, SharedWorkOptimizer
// If we do, we cannot merge. The reason is that Tez currently does
// not support parallel edges, i.e., multiple edges from same work x
// into same work y.
+ EdgePredicate edgePredicate;
+ if
(pctx.getConf().getBoolVar(ConfVars.HIVE_SHARED_WORK_PARALLEL_EDGE_SUPPORT)) {
+ edgePredicate = new EdgePredicate(EnumSet.<EdgeType> of(EdgeType.DPP,
EdgeType.SEMIJOIN, EdgeType.BROADCAST));
+ } else {
+ edgePredicate = new EdgePredicate(EnumSet.<EdgeType> of(EdgeType.DPP));
Review comment:
If I understand correctly the old behavior didn't allow `DPP` edge
types. Should we follow that if
`hive.optimize.shared.work.parallel.edge.support` is false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 543382)
Time Spent: 20m (was: 10m)
> Add feature toggle to control SWO parallel edge support
> -------------------------------------------------------
>
> Key: HIVE-24678
> URL: https://issues.apache.org/jira/browse/HIVE-24678
> Project: Hive
> Issue Type: Sub-task
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I can't foresee the future - but it might give better diagnosability
> opportunities to have a direct knob on this feature (I wanted to add it in
> the base patch ; but eventually forgot to do so)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
