[ 
https://issues.apache.org/jira/browse/HIVE-24458?focusedWorklogId=542952&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542952
 ]

ASF GitHub Bot logged work on HIVE-24458:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jan/21 17:37
            Start Date: 27/Jan/21 17:37
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on a change in pull request #1726:
URL: https://github.com/apache/hive/pull/1726#discussion_r565500287



##########
File path: 
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java
##########
@@ -162,6 +162,11 @@ public boolean isNeeded() {
    */
   public ExpressionTree getExpression();
 
+  /**
+   * Get the expression tree without the

Review comment:
       unfinished sentece
   

##########
File path: 
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java
##########
@@ -162,6 +162,11 @@ public boolean isNeeded() {
    */
   public ExpressionTree getExpression();
 
+  /**
+   * Get the expression tree without the
+   */
+  public ExpressionTree getUnexpandedExpression();

Review comment:
       I find `unexpanded` a little strange - a different keyword might fit 
this thing better (what do you think about compact or  original).
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 542952)
    Time Spent: 20m  (was: 10m)

> Allow access to SArgs without converting to disjunctive normal form
> -------------------------------------------------------------------
>
>                 Key: HIVE-24458
>                 URL: https://issues.apache.org/jira/browse/HIVE-24458
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> For some use cases, it is useful to have access to the SArg expression in a 
> non-normalized form. Currently, the SArg only provides the fully normalized 
> expression.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to