[
https://issues.apache.org/jira/browse/HIVE-24601?focusedWorklogId=542344&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542344
]
ASF GitHub Bot logged work on HIVE-24601:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/21 19:06
Start Date: 26/Jan/21 19:06
Worklog Time Spent: 10m
Work Description: zabetak opened a new pull request #1875:
URL: https://github.com/apache/hive/pull/1875
### What changes were proposed in this pull request?
1. Add `hive.cbo.fallback.strategy` and plug it to the planner
2. Replace usage of `hive.in.test` in planner with
`hive.cbo.fallback.strategy`
### Why are the changes needed?
1. Provide the means to fail-fast when CBO failures appear (even in
production)
2. Allow finer control on tests requiring to fail on CBO, legacy, or both
### Does this PR introduce _any_ user-facing change?
No at its current state.
I was thinking to even drop the `CONSERVATIVE` option. The CBO error is
always logged (not hidden) so I don't see why we should complicate the decision
more.
### How was this patch tested?
`mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile_regex="cbo_fallback.*" `
`mvn test -Dtest=TestNegativeCliDriver -Dqfile_regex="cbo_fallback.*" `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 542344)
Time Spent: 2h (was: 1h 50m)
> Control CBO fallback behavior via property
> ------------------------------------------
>
> Key: HIVE-24601
> URL: https://issues.apache.org/jira/browse/HIVE-24601
> Project: Hive
> Issue Type: Improvement
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> When CBO optimizer fails there is a fallback mechanism(HIVE-7413) that will
> retry to process the query using the legacy Hive optimizer.
> There are use-cases where this behavior is not desirable notably for the
> tests (HIVE-16058) but also for end users who would like to disable the
> fall-back mechanism to avoid running problematic queries without realizing.
> The goal of this issue is to introduce a dedicated Hive property controlling
> this behavior,{{hive.cbo.fallback.enable}}, for both tests and production.
> The default value should be true and tests should run with this property set
> to false.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
