[
https://issues.apache.org/jira/browse/HIVE-22981?focusedWorklogId=541917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-541917
]
ASF GitHub Bot logged work on HIVE-22981:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/21 04:32
Start Date: 26/Jan/21 04:32
Worklog Time Spent: 10m
Work Description: kgyrtkirk merged pull request #1686:
URL: https://github.com/apache/hive/pull/1686
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 541917)
Time Spent: 1.5h (was: 1h 20m)
> DataFileReader is not closed in
> AvroGenericRecordReader#extractWriterTimezoneFromMetadata
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-22981
> URL: https://issues.apache.org/jira/browse/HIVE-22981
> Project: Hive
> Issue Type: Bug
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.1.3, 3.2.0, 4.0.0
>
> Attachments: HIVE-22981.01.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Method looks like :
> {code}
> private ZoneId extractWriterTimezoneFromMetadata(JobConf job, FileSplit
> split,
> GenericDatumReader<GenericRecord> gdr) throws IOException {
> if (job == null || gdr == null || split == null || split.getPath() ==
> null) {
> return null;
> }
> try {
> DataFileReader<GenericRecord> dataFileReader =
> new DataFileReader<GenericRecord>(new FsInput(split.getPath(),
> job), gdr);
> [...return...]
> }
> } catch (IOException e) {
> // Can't access metadata, carry on.
> }
> return null;
> }
> {code}
> The DataFileReader is never closed which can cause a memory leak. We need a
> try-with-resources here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
