[
https://issues.apache.org/jira/browse/HIVE-24672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269588#comment-17269588
]
Mustafa İman commented on HIVE-24672:
-------------------------------------
merged to master, thanks for reviews [~amagyar], [~abstractdog]
> compute_stats_long.q fails for wrong reasons
> --------------------------------------------
>
> Key: HIVE-24672
> URL: https://issues.apache.org/jira/browse/HIVE-24672
> Project: Hive
> Issue Type: Bug
> Reporter: Mustafa İman
> Assignee: Mustafa İman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> TestNegativeCliDriver[compute_stats_long] intends to test fmsketch has a hard
> limit on number of bit vectors (1024). However, the test fails for the
> following wrong reason.
> {code:java}
> Caused by: java.lang.RuntimeException: Can not recognize 10000Caused by:
> java.lang.RuntimeException: Can not recognize 10000 at
> org.apache.hadoop.hive.common.ndv.NumDistinctValueEstimatorFactory.getEmptyNumDistinctValueEstimator(NumDistinctValueEstimatorFactory.java:71)
> {code}
> Instead it should fail with
> {code:java}
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: The maximum
> allowed value for number of bit vectors is 1024, but was passed 10000 bit
> vectorsCaused by: org.apache.hadoop.hive.ql.metadata.HiveException: The
> maximum allowed value for number of bit vectors is 1024, but was passed
> 10000 bit vectors at
> org.apache.hadoop.hive.ql.udf.generic.GenericUDAFComputeBitVectorFMSketch$NumericStatsEvaluator.iterate(GenericUDAFComputeBitVectorFMSketch.java:125)
> ~[hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> {code}
> Since this function is superseeded by compute_bit_vector_fm, it is best if we
> add the same test for compute_bit_vector_fm too.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
