[
https://issues.apache.org/jira/browse/HIVE-24637?focusedWorklogId=539246&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539246
]
ASF GitHub Bot logged work on HIVE-24637:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/21 18:23
Start Date: 21/Jan/21 18:23
Worklog Time Spent: 10m
Work Description: johan-g commented on a change in pull request #1870:
URL: https://github.com/apache/hive/pull/1870#discussion_r562102132
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java
##########
@@ -39,7 +40,16 @@
}
private abstract static class BaseUpdateFunction implements UpdateFunction {
- private static final int PRINT_INTERVAL = 3000;
+ private static final long PRINT_INTERVAL;
+
+ static {
Review comment:
Thanks for the feedback @kgyrtkirk, I've added a `getHiveConf` function
to `TezJobMonitor` and move this logic to the constructor of
`BaseUpdateFunction`. I guess another approach could be to get `HiveConf` from
`SessionState` which is used in the constructor for `perfLogger` already, but
grepping for other cases of this approach it doesn't seem to common.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 539246)
Time Spent: 0.5h (was: 20m)
> Make Tez progress log interval configurable
> -------------------------------------------
>
> Key: HIVE-24637
> URL: https://issues.apache.org/jira/browse/HIVE-24637
> Project: Hive
> Issue Type: Improvement
> Components: Clients
> Affects Versions: 2.4.0, 3.1.2, 4.0.0
> Reporter: Johan Gustavsson
> Assignee: Zoltan Haindrich
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In case of hive on MR we can configure how often the progress log is updated
> in the client side with the parameter
> [https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L2041-L2050]
> while in case of Hive on Tez this value is hard coded here
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java#L42].
> The default value in Tez is also significantly shorter than that of MR (6 VS
> 3 S) meaning for longer queries the client log can get very long.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
