[
https://issues.apache.org/jira/browse/HIVE-22944?focusedWorklogId=539242&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539242
]
ASF GitHub Bot logged work on HIVE-22944:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/21 18:21
Start Date: 21/Jan/21 18:21
Worklog Time Spent: 10m
Work Description: abstractdog commented on a change in pull request #1798:
URL: https://github.com/apache/hive/pull/1798#discussion_r562100712
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java
##########
@@ -278,7 +284,7 @@ public Kryo create() {
* @return kryo instance
*/
public static Kryo borrowKryo() {
- Kryo kryo = kryoPool.borrow();
+ Kryo kryo = kryoPool.obtain();
Review comment:
it's very unfortunate that kryo changed this method name without any
reasons (or just I don't understand that :) )...we might want a method name
that reflects the behavior of "getting a kryo instance from the pool", I don't
have a strong opinion about that, but I'm not sure if we need to change a
public method name because kryo changed theirs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 539242)
Time Spent: 1h (was: 50m)
> Upgrade to Kryo5
> ----------------
>
> Key: HIVE-22944
> URL: https://issues.apache.org/jira/browse/HIVE-22944
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22944.01.patch, kryo4_vs_5_benchmark.log
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Maybe we should consider upgrading to kryo5 (plan ser/deser). Not sure about
> performance benefits, but looking at the code, e.g. FieldSerializer in Kryo5
> seems to let us extend it easier (less private fields), which could be a
> benefit if we want to change its behavior, e.g. defining different logic for
> different fields of an object.
> Kryo 4 FieldSerializer:
> https://github.com/EsotericSoftware/kryo/blob/kryo-4/src/com/esotericsoftware/kryo/serializers/FieldSerializer.java
> Kryo 5 FieldSerialier:
> https://github.com/EsotericSoftware/kryo/blob/master/src/com/esotericsoftware/kryo/serializers/FieldSerializer.java
> UPDATE: currently we are at kryo 5.0.3
> TODO: why kryo-shaded artifact has been used so far?
> https://javalibs.com/artifact/com.esotericsoftware/kryo-shaded
> "This contains the shaded reflectasm jar to prevent conflicts with other
> versions of asm."
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
