[
https://issues.apache.org/jira/browse/HIVE-24661?focusedWorklogId=538147&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-538147
]
ASF GitHub Bot logged work on HIVE-24661:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/21 00:10
Start Date: 20/Jan/21 00:10
Worklog Time Spent: 10m
Work Description: miklosgergely commented on a change in pull request
#1889:
URL: https://github.com/apache/hive/pull/1889#discussion_r560585140
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
##########
@@ -1028,11 +1028,11 @@ public boolean checkFailedCompactions(CompactionInfo
ci) throws MetaException {
return (numFailed == failedThreshold) && !needsRetry;
}
catch (SQLException e) {
- LOG.error("Unable to check for failed compactions " + e.getMessage());
+ LOG.error("Unable to check for failed compactions" + e.getMessage());
Review comment:
I don't see any reason not to log out the full stack trace even if we
have to retry it later, but if we decide to log only the error message, then we
need that space, or even better a ": ".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 538147)
Time Spent: 20m (was: 10m)
> Do Not "Stringify" Exception in Logger messages
> -----------------------------------------------
>
> Key: HIVE-24661
> URL: https://issues.apache.org/jira/browse/HIVE-24661
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> SLF4J already has support for pretty-printing Exceptions. No need to
> manually do it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
