[
https://issues.apache.org/jira/browse/HIVE-24652?focusedWorklogId=537734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-537734
]
ASF GitHub Bot logged work on HIVE-24652:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/21 10:28
Start Date: 19/Jan/21 10:28
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1881:
URL: https://github.com/apache/hive/pull/1881#discussion_r560072484
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -102,11 +102,16 @@ public void run() {
ExecutorService executor = getTimeoutHandlingExecutor();
try {
do {
- Future<Boolean> singleRun = executor.submit(() ->
findNextCompactionAndExecute(computeStats));
+ Ref<CompactionInfo> ci = new Ref<>(null);
+ Future<Boolean> singleRun = executor.submit(() ->
findNextCompactionAndExecute(computeStats, ci));
Review comment:
Wouldn't it be more natural to have a complex return type, like below?
Definitely not a final proposal just some food for thought.
```
private static class ExecutionResult {
private Boolean singleRun;
private CompactionInfo failedCompaction;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 537734)
Time Spent: 0.5h (was: 20m)
> If compactor worker times out, compaction is not cleared from queue
> -------------------------------------------------------------------
>
> Key: HIVE-24652
> URL: https://issues.apache.org/jira/browse/HIVE-24652
> Project: Hive
> Issue Type: Improvement
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If worker is timed out (that is, takes longer than value of
> hive.compactor.worker.timeout) then the corresponding entry is not cleared
> from the COMPACTION_QUEUE table, the entry is left in state "working" or
> "initiated" which means that compaction can't be run again on the
> table/partition.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
