[
https://issues.apache.org/jira/browse/HIVE-24627?focusedWorklogId=534942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534942
]
ASF GitHub Bot logged work on HIVE-24627:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/21 17:32
Start Date: 12/Jan/21 17:32
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1859:
URL: https://github.com/apache/hive/pull/1859#discussion_r555950877
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -874,17 +881,21 @@ private void openSession() throws SQLException {
}
// set the session configuration
- if (sessConfMap.containsKey(HiveAuthConstants.HS2_PROXY_USER)) {
- openConf.put(HiveAuthConstants.HS2_PROXY_USER,
- sessConfMap.get(HiveAuthConstants.HS2_PROXY_USER));
+ final String hs2ProxyUser =
sessConfMap.get(HiveAuthConstants.HS2_PROXY_USER);
+ if (hs2ProxyUser != null) {
+ LOG.debug("Set hive.server2.proxy.user: {}", hs2ProxyUser);
+ openConf.put(HiveAuthConstants.HS2_PROXY_USER, hs2ProxyUser);
}
// set create external purge table by default
if
(sessConfMap.containsKey(JdbcConnectionParams.CREATE_TABLE_AS_EXTERNAL)) {
openConf.put("set:hiveconf:hive.create.as.external.legacy",
sessConfMap.get(JdbcConnectionParams.CREATE_TABLE_AS_EXTERNAL).toLowerCase());
}
- if (isHplSqlMode()) {
+
Review comment:
Ya. I wanted to log them differently since they have different sources
(and I wanted to preserve the source), but I guess it uses `set:hiveconf`
`set:hivevar` in the key property so the source will be known. Thanks. Changed.
I did keep the 'table name' since that is just all around useful information
that I wouldn't want to go digging for in the big configuration map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 534942)
Time Spent: 0.5h (was: 20m)
> Add Debug Logging to Hive JDBC Connection
> -----------------------------------------
>
> Key: HIVE-24627
> URL: https://issues.apache.org/jira/browse/HIVE-24627
> Project: Hive
> Issue Type: Improvement
> Components: JDBC
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Log the following:
> # Session handle
> # Version Number
> # Any configurations/variables set by the user at the client-side
> # Dump the Hive configurations at session-start
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
