[
https://issues.apache.org/jira/browse/HIVE-24586?focusedWorklogId=532485&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532485
]
ASF GitHub Bot logged work on HIVE-24586:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/21 13:49
Start Date: 07/Jan/21 13:49
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1831:
URL: https://github.com/apache/hive/pull/1831#discussion_r553337123
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3147,12 +3147,11 @@ private static void
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
new RangeValidator(0, 100), "Determines how many failed compaction
records will be " +
"retained in compaction history for a given table/partition."),
/**
- * @deprecated Use MetastoreConf.COMPACTOR_HISTORY_RETENTION_ATTEMPTED
+ * @deprecated Use
MetastoreConf.COMPACTOR_HISTORY_RETENTION_DID_NOT_INITIATE
*/
- @Deprecated
-
COMPACTOR_HISTORY_RETENTION_ATTEMPTED("hive.compactor.history.retention.attempted",
2,
- new RangeValidator(0, 100), "Determines how many attempted compaction
records will be " +
- "retained in compaction history for a given table/partition."),
+ @Deprecated
COMPACTOR_HISTORY_RETENTION_DID_NOT_INITIATE("hive.compactor.history.retention.attempted",
2,
Review comment:
Could we use configuration deprecation to change the name of the config
as well? Otherwise we will carry this baggage forever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 532485)
Time Spent: 1h (was: 50m)
> Rename compaction "attempted" status
> ------------------------------------
>
> Key: HIVE-24586
> URL: https://issues.apache.org/jira/browse/HIVE-24586
> Project: Hive
> Issue Type: Improvement
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> A compaction with "attempted" status sounds like compactor tried to compact
> the table/partition and failed. In reality it means one of these:
> * the Initiator did not queue compaction because the number of previously
> failed compactions has passed a threshold
> * the Initiator did not queue compaction because of an error
> In both these cases the user is still able initiate compaction manually. This
> should be made clearer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
