[
https://issues.apache.org/jira/browse/HIVE-24415?focusedWorklogId=530875&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530875
]
ASF GitHub Bot logged work on HIVE-24415:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/21 20:29
Start Date: 04/Jan/21 20:29
Worklog Time Spent: 10m
Work Description: ramesh0201 commented on a change in pull request #1701:
URL: https://github.com/apache/hive/pull/1701#discussion_r551551287
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java
##########
@@ -385,7 +387,11 @@ public HiveSplitGenerator(InputInitializerContext
initializerContext) throws IOE
@Override
public void onVertexStateUpdated(VertexStateUpdate stateUpdate) {
- pruner.processVertex(stateUpdate.getVertexName());
+ // pruner registers for vertex state updates after it is ready to handle
them
+ // so we do not worry about events coming before pruner was initialized
+ if (pruner != null) {
Review comment:
I can understand status updates are not needed when not initialized. Is
the not null check only for safety or did we introduce any new place where we
start assigning null values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 530875)
Time Spent: 0.5h (was: 20m)
> HiveSplitGenerator blocks Tez dispatcher
> ----------------------------------------
>
> Key: HIVE-24415
> URL: https://issues.apache.org/jira/browse/HIVE-24415
> Project: Hive
> Issue Type: Improvement
> Reporter: Mustafa İman
> Assignee: Mustafa İman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HiveSplitGenerator does a lot of heavyweight operations in its constructor.
> These operations block AsyncDispatcher in Tez
> [https://github.com/apache/tez/blob/989d286d09cac7c4e4c5a0e06dd75ea5a6f15478/tez-dag/src/main/java/org/apache/tez/dag/app/dag/RootInputInitializerManager.java#L141]
> . We should move bulk of initialization out of constructor.
> The only reason of setting up everything in constructor is
> DynamicPartitionPruner. We can buffer incoming events in HiveSplitGenerator
> until dynamic partition pruner is initialized.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
