[
https://issues.apache.org/jira/browse/HIVE-12371?focusedWorklogId=529711&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529711
]
ASF GitHub Bot logged work on HIVE-12371:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Dec/20 06:51
Start Date: 31/Dec/20 06:51
Worklog Time Spent: 10m
Work Description: jshmchenxi commented on a change in pull request #1611:
URL: https://github.com/apache/hive/pull/1611#discussion_r550411547
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -1002,11 +1002,19 @@ private String getSessionValue(String varName, String
varDefault) {
return varValue;
}
- // copy loginTimeout from driver manager. Thrift timeout needs to be in
millis
+ // use socketTimeout from jdbc connection url. Thrift timeout needs to be in
millis
private void setupLoginTimeout() {
- long timeOut = TimeUnit.SECONDS.toMillis(DriverManager.getLoginTimeout());
+ String socketTimeoutStr =
sessConfMap.getOrDefault(JdbcConnectionParams.SOCKET_TIMEOUT, "0");
+ long timeOut = 0;
Review comment:
Sorry for the late reply. If users depends on DriverManager.loginTimeout
to control HS2 jdbc timeout, they will have to refactor their code after
applying this. However, we haven't yet met a situation that we need this
timeout to return quickly when HS2 hangs or something. Our problem is when
submitting a big query which needs minutes to compile, the connection is lost
because of this DriverManager.loginTimeout. Maybe we need to set a timeout
parameter for HS2 on the server side too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 529711)
Time Spent: 1h 50m (was: 1h 40m)
> Adding a timeout connection parameter for JDBC
> ----------------------------------------------
>
> Key: HIVE-12371
> URL: https://issues.apache.org/jira/browse/HIVE-12371
> Project: Hive
> Issue Type: Improvement
> Components: JDBC
> Reporter: Nemon Lou
> Assignee: Xi Chen
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> There are some timeout settings from server side:
> HIVE-4766
> HIVE-6679
> Adding a timeout connection parameter for JDBC is useful in some scenario:
> 1,beeline (which can not set timeout manually)
> 2,customize timeout for different connections (among hive or RDBs,which can
> not be done via DriverManager.setLoginTimeout())
> Just like postgresql,
> {noformat}
> jdbc:postgresql://localhost/test?user=fred&password=secret&ssl=true&connectTimeout=0
> {noformat}
> or mysql
> {noformat}
> jdbc:mysql://xxx.xx.xxx.xxx:3306/database?connectTimeout=60000&socketTimeout=60000
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
