[ https://issues.apache.org/jira/browse/HIVE-24535?focusedWorklogId=524112&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524112 ]
ASF GitHub Bot logged work on HIVE-24535: ----------------------------------------- Author: ASF GitHub Bot Created on: 14/Dec/20 21:00 Start Date: 14/Dec/20 21:00 Worklog Time Spent: 10m Work Description: pvargacl opened a new pull request #1779: URL: https://github.com/apache/hive/pull/1779 ### What changes were proposed in this pull request? - AcidUtils.getAcidState is doing a recursive listing on S3 FileSystem, it already knows the content of each delta and base directory, this could be returned to OrcInputFormat, to avoid listing each delta directory again there. - AcidUtils.getAcidstate submethods are collecting more and more infos about the state of the data directory. This could be done directly to the final Directory object to avoid 10+ parameters in methods. - AcidUtils.Directory, OrcInputFormat.AcidDirInfo and AcidUtils.TxnBase can be merged to one class, to clean up duplications. ### Why are the changes needed? - performance improvement ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing unit tests ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 524112) Remaining Estimate: 0h Time Spent: 10m > Cleanup AcidUtils.Directory and remove unnecessary filesystem listings > ---------------------------------------------------------------------- > > Key: HIVE-24535 > URL: https://issues.apache.org/jira/browse/HIVE-24535 > Project: Hive > Issue Type: Improvement > Reporter: Peter Varga > Assignee: Peter Varga > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > * AcidUtils.getAcidState is doing a recursive listing on S3 FileSystem, it > already knows the content of each delta and base directory, this could be > returned to OrcInputFormat, to avoid listing each delta directory again there. > * AcidUtils.getAcidstate submethods are collecting more and more infos about > the state of the data directory. This could be done directly to the final > Directory object to avoid 10+ parameters in methods. > * AcidUtils.Directory, OrcInputFormat.AcidDirInfo and AcidUtils.TxnBase can > be merged to one class, to clean up duplications. -- This message was sent by Atlassian Jira (v8.3.4#803005)