[ 
https://issues.apache.org/jira/browse/HIVE-23980?focusedWorklogId=518111&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-518111
 ]

ASF GitHub Bot logged work on HIVE-23980:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Nov/20 20:17
            Start Date: 30/Nov/20 20:17
    Worklog Time Spent: 10m 
      Work Description: viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-736018282


   > Thanks @viirya ! the new PR looks almost good to me except one nit.
   > 
   > Also comparing to the original patch, we don't have changes to 
`HiveRelDecorrelator`, `HiveAggregate` and `HiveSubQueryRemoveRule`. This is 
unnecessary because we've shaded Guava within `hive-exec`? (some of the APIs 
like `operandJ` do not exist in the Calcite version used by branch-2.3 also).
   
   
   The change to `HiveAggregate` just to remove unused parameter `groupSets` in 
`deriveRowType`. Not related to shading guava, so I don't apply it.
   
   The change from `operand` to `operandJ` in `HiveSubQueryRemoveRule` and 
`HiveRelDecorrelator`, cannot apply to branch-2.3 because `operandJ` is not in 
calcite 1.10.0. The API was add since calcite 1.17.0 
(https://github.com/apache/calcite/commit/d59b639d/).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 518111)
    Time Spent: 5h  (was: 4h 50m)

> Shade guava from existing Hive versions
> ---------------------------------------
>
>                 Key: HIVE-23980
>                 URL: https://issues.apache.org/jira/browse/HIVE-23980
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.3.7
>            Reporter: L. C. Hsieh
>            Assignee: L. C. Hsieh
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-23980.01.branch-2.3.patch
>
>          Time Spent: 5h
>  Remaining Estimate: 0h
>
> I'm trying to upgrade Guava version in Spark. The JIRA ticket is SPARK-32502.
> Running test hits an error:
> {code}
> sbt.ForkMain$ForkError: sbt.ForkMain$ForkError: java.lang.IllegalAccessError: 
> tried to access method 
> com.google.common.collect.Iterators.emptyIterator()Lcom/google/common/collect/UnmodifiableIterator;
>  from class org.apache.hadoop.hive.ql.exec.FetchOperator
>       at 
> org.apache.hadoop.hive.ql.exec.FetchOperator.<init>(FetchOperator.java:108)
>       at 
> org.apache.hadoop.hive.ql.exec.FetchTask.initialize(FetchTask.java:87)
>       at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:541)
>       at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317)
>       at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457)
>       at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1237)
>       at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1227)
> {code}
> I know that hive-exec doesn't shade Guava until HIVE-22126 but that work 
> targets 4.0.0. I'm wondering if there is a solution for current Hive 
> versions, e.g. Hive 2.3.7? Any ideas?
> Thanks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to