[
https://issues.apache.org/jira/browse/HIVE-24230?focusedWorklogId=515515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515515
]
ASF GitHub Bot logged work on HIVE-24230:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/20 12:20
Start Date: 23/Nov/20 12:20
Worklog Time Spent: 10m
Work Description: zeroflag commented on a change in pull request #1633:
URL: https://github.com/apache/hive/pull/1633#discussion_r528663855
##########
File path:
hplsql/src/main/java/org/apache/hive/hplsql/executor/JdbcQueryExecutor.java
##########
@@ -0,0 +1,101 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.hive.hplsql.executor;
+
+import java.sql.ResultSet;
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+import org.antlr.v4.runtime.ParserRuleContext;
+import org.apache.hive.hplsql.Exec;
+import org.apache.hive.hplsql.Query;
+
+public class JdbcQueryExecutor implements QueryExecutor {
+ private final Exec exec;
+
+ public JdbcQueryExecutor(Exec exec) {
+ this.exec = exec;
+ }
+
+ @Override
+ public QueryResult executeQuery(String sql, ParserRuleContext ctx) {
+ String conn = exec.getStatementConnection();
+ Query query = exec.executeQuery(ctx, new Query(sql), conn);
+ ResultSet resultSet = query.getResultSet();
+ if (resultSet == null) { // offline mode
+ return new QueryResult(null, () -> new
Metadata(Collections.emptyList()), query.getException());
+ } else {
+ return new QueryResult(new JdbcRowResult(resultSet), () ->
metadata(resultSet), query.getException());
+ }
+ }
+
+ private static Metadata metadata(ResultSet resultSet) {
+ try {
+ ResultSetMetaData meta = resultSet.getMetaData();
+ List<ColumnMeta> colMetas = new ArrayList<>();
+ for (int i = 1; i <= meta.getColumnCount(); i++) {
+ colMetas.add(new ColumnMeta(
+ meta.getColumnName(i), meta.getColumnTypeName(i),
meta.getColumnType(i)));
+ }
+ return new Metadata(colMetas);
+ } catch (SQLException e) {
+ throw new QueryException(e);
+ }
+ }
+
+ private static class JdbcRowResult implements RowResult {
+ private final ResultSet resultSet;
+
+ private JdbcRowResult(ResultSet resultSet) {
+ this.resultSet = resultSet;
+ }
+
+ @Override
+ public boolean next() {
+ try {
+ return resultSet.next();
+ } catch (SQLException e) {
+ throw new QueryException(e);
+ }
+ }
+
+ @Override
+ public <T> T get(int columnIndex, Class<T> type) {
+ try {
+ return resultSet.getObject(columnIndex, type);
Review comment:
Right, this is off by one. the Jdbc adaptor was added for compatibility,
I'm not sure for how long we'll want to support it but I fixed indexing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 515515)
Time Spent: 2.5h (was: 2h 20m)
> Integrate HPL/SQL into HiveServer2
> ----------------------------------
>
> Key: HIVE-24230
> URL: https://issues.apache.org/jira/browse/HIVE-24230
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, hpl/sql
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> HPL/SQL is a standalone command line program that can store and load scripts
> from text files, or from Hive Metastore (since HIVE-24217). Currently HPL/SQL
> depends on Hive and not the other way around.
> Changing the dependency order between HPL/SQL and HiveServer would open up
> some possibilities which are currently not feasable to implement. For example
> one might want to use a third party SQL tool to run selects on stored
> procedure (or rather function in this case) outputs.
> {code:java}
> SELECT * from myStoredProcedure(1, 2); {code}
> HPL/SQL doesn’t have a JDBC interface and it’s not a daemon so this would not
> work with the current architecture.
> Another important factor is performance. Declarative SQL commands are sent to
> Hive via JDBC by HPL/SQL. The integration would make it possible to drop JDBC
> and use HiveSever’s internal API for compilation and execution.
> The third factor is that existing tools like Beeline or Hue cannot be used
> with HPL/SQL since it has its own, separated CLI.
>
> To make it easier to implement, we keep things separated in the inside at
> first, by introducing a hive session level JDBC parameter.
> {code:java}
> jdbc:hive2://localhost:10000/default;hplsqlMode=true {code}
>
> The hplsqlMode indicates that we are in procedural SQL mode where the user
> can create and call stored procedures. HPLSQL allows you to write any kind of
> procedural statement at the top level. This patch doesn't limit this but it
> might be better to eventually restrict what statements are allowed outside of
> stored procedures.
>
> Since HPLSQL and Hive are running in the same process there is no need to use
> the JDBC driver between them. The patch adds an abstraction with 2 different
> implementations, one for executing queries on JDBC (for keeping the existing
> behaviour) and another one for directly calling Hive's compiler. In HPLSQL
> mode the latter is used.
> In the inside a new operation (HplSqlOperation) and operation type
> (PROCEDURAL_SQL) was added which works similar to the SQLOperation but it
> uses the hplsql interpreter to execute arbitrary scripts. This operation
> might spawns new SQLOpertions.
> For example consider the following statement:
> {code:java}
> FOR i in 1..10 LOOP
> SELECT * FROM table
> END LOOP;{code}
> We send this to beeline while we'er in hplsql mode. Hive will create a hplsql
> interpreter and store it in the session state. A new HplSqlOperation is
> created to run the script on the interpreter.
> HPLSQL knows how to execute the for loop, but i'll call Hive to run the
> select expression. The HplSqlOperation is notified when the select reads a
> row and accumulates the rows into a RowSet (memory consumption need to be
> considered here) which can be retrieved via thrift from the client side.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
