[
https://issues.apache.org/jira/browse/HIVE-24401?focusedWorklogId=514032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514032
]
ASF GitHub Bot logged work on HIVE-24401:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/20 09:51
Start Date: 19/Nov/20 09:51
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #1683:
URL: https://github.com/apache/hive/pull/1683#discussion_r526728324
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3113,8 +3113,8 @@ private static void populateLlapDaemonVarsSet(Set<String>
llapDaemonVarsSetLocal
HIVE_COMPACTOR_COMPACT_MM("hive.compactor.compact.insert.only", true,
"Whether the compactor should compact insert-only tables. A safety
switch."),
COMPACTOR_CRUD_QUERY_BASED("hive.compactor.crud.query.based", false,
- "Means Major compaction on full CRUD tables is done as a query, "
- + "and minor compaction will be disabled."),
+ "Means compaction on full CRUD tables is done as a query. "
+ + "Compactions on insert-only tables will always run as a query."),
Review comment:
Thanks for taking care of this!
I'd add to the end: "regardless of the value of this configuration" just so
it's clear.
and "as **a** query" isn't exactly accurate, I'd change it to something
like: "via queries"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 514032)
Time Spent: 50m (was: 40m)
> COMPACTOR_CRUD_QUERY_BASED description in HiveConf is outdated
> --------------------------------------------------------------
>
> Key: HIVE-24401
> URL: https://issues.apache.org/jira/browse/HIVE-24401
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> minor query based compaction is implemented
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
