[
https://issues.apache.org/jira/browse/HIVE-24349?focusedWorklogId=512797&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-512797
]
ASF GitHub Bot logged work on HIVE-24349:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/20 09:33
Start Date: 17/Nov/20 09:33
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1655:
URL: https://github.com/apache/hive/pull/1655#discussion_r525009064
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -790,6 +790,9 @@ public void close() {
try {
if (null != client) {
client.shutdown();
+ if ((transport == null) || !transport.isOpen()) {
+ LOG.info("Closed a connection to metastore, current connections: " +
connCount.decrementAndGet());
Review comment:
You can use substitution while logging like it is in other place in
method. If possible please add a test for counter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 512797)
Time Spent: 0.5h (was: 20m)
> Client connection count is not printed correctly in HiveMetastoreClient
> -----------------------------------------------------------------------
>
> Key: HIVE-24349
> URL: https://issues.apache.org/jira/browse/HIVE-24349
> Project: Hive
> Issue Type: Bug
> Reporter: Arko Sharma
> Assignee: Arko Sharma
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-24349.01.patch, HIVE-24349.02.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
