[
https://issues.apache.org/jira/browse/HIVE-24340?focusedWorklogId=510244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510244
]
ASF GitHub Bot logged work on HIVE-24340:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/20 13:32
Start Date: 11/Nov/20 13:32
Worklog Time Spent: 10m
Work Description: szlta commented on a change in pull request #1658:
URL: https://github.com/apache/hive/pull/1658#discussion_r521359714
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -150,6 +151,8 @@ private LlapIoImpl(Configuration conf) throws IOException {
LowLevelCachePolicy
realCachePolicy =
useLrfu ? new LowLevelLrfuCachePolicy(minAllocSize, totalMemorySize,
conf) : new LowLevelFifoCachePolicy();
+ // TODO: if realCachePolicy is not something that supports proactive
caching
Review comment:
Agreed - however with the PR being approved and having green tests I
won't change just this comment, it will be removed with the next patch in line
(https://issues.apache.org/jira/browse/HIVE-24341) anyway, very shortly :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 510244)
Time Spent: 0.5h (was: 20m)
> Mark phase for proactive cache eviction
> ---------------------------------------
>
> Key: HIVE-24340
> URL: https://issues.apache.org/jira/browse/HIVE-24340
> Project: Hive
> Issue Type: Sub-task
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
