[ https://issues.apache.org/jira/browse/HIVE-24275?focusedWorklogId=507044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507044 ]
ASF GitHub Bot logged work on HIVE-24275: ----------------------------------------- Author: ASF GitHub Bot Created on: 03/Nov/20 14:14 Start Date: 03/Nov/20 14:14 Worklog Time Spent: 10m Work Description: pvargacl opened a new pull request #1644: URL: https://github.com/apache/hive/pull/1644 ### What changes were proposed in this pull request? Rebased @vpnvishv patch that added support to delay cleanup of obsolete files/dirs with user configured value. (#1583) In this PR the commit_time stored in a separated field in the compaction queue, changed the filter logic in the cleaner when multiple compaction was running for the same partition, added more test ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 507044) Time Spent: 1.5h (was: 1h 20m) > Configurations to delay the deletion of obsolete files by the Cleaner > --------------------------------------------------------------------- > > Key: HIVE-24275 > URL: https://issues.apache.org/jira/browse/HIVE-24275 > Project: Hive > Issue Type: New Feature > Reporter: Kishen Das > Assignee: Peter Varga > Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > Whenever compaction happens, the cleaner immediately deletes older obsolete > files. In certain cases it would be beneficial to retain these for certain > period. For example : if you are serving the file metadata from cache and > don't want to invalidate the cache during compaction because of performance > reasons. > For this purpose we should introduce a configuration > hive.compactor.delayed.cleanup.enabled, which if enabled will delay the > cleaning up obsolete files. There should be a separate configuration > CLEANER_RETENTION_TIME to specify the duration till which we should retain > these older obsolete files. > It might be beneficial to have one more configuration to decide whether to > retain files involved in an aborted transaction > hive.compactor.aborted.txn.delayed.cleanup.enabled . -- This message was sent by Atlassian Jira (v8.3.4#803005)